• No results found

Guidelines on communication with code developer 1. Guidelines for the code developer and vendor

In document ercoftac_best_practice_guide.pdf (Page 89-94)

tor Radial squeeze factor

11. Checklist of best practice advice for industrial CFD

11.14. Guidelines on communication with code developer 1. Guidelines for the code developer and vendor

¾ The code developer or code vendor needs to demonstrate that he has applied stringent methods of quality control of the software development and maintenance.

¾ Verification of the code is to be carried out by the code vendor or developer, and he should pro-vide the necessary information on the verification process for the user.

¾ The code developer or code vendor should maintain and publish a databank of verification test cases that are used for testing. The cases should include simple code verifications tests (e.g. that solutions are independent of co-ordinate systems).

¾ The code developer or code vendor should provide documentary evidence of the verification tests that the software has undergone, which should include clearly details of the code options which are used during testing.

¾ For all new versions of the code and all new machines a standard set of verification test cases should be repeated.

¾ Code vendors and code developers should supply a list of known bugs and errors in each version of the code (hot-line, password secured web-page). This list should demonstrate that the number of bugs reduces as the code matures.

¾ The code developers should try to include warning notices and guidance for the user in the output.

For example, when basic rules on grid generation (expansion ratios, skew, etc.) are being broken, when important specific default options are being overruled by the code input data or when the near wall grid is inconsistent with the turbulence modelling.

11.14.2. Guidelines for the code user

¾ Read the release notes issued by the code supplier, as these are a good source of information on changes to the code to remove existing bugs.

¾ Recognise that codes can only be validated and verified for a class of problems involving specific variables. If the application involves an area where the code is not fully verified there is more risk of code errors.

¾ Set up a suite of test cases that can be run on new code releases to provide an independent check on the code and to highlight any changes between releases (for example in default parame-ters).

¾ Check that the release version of the code is compatibility with any user defined routines, if appli-cable.

¾ When a code error is suspected, communicate this to the code vendor or developer as soon as possible, especially if no list of known bugs has been published. Other users may then profit from this experience. If the bug is well-known a solution or work-around may already be available.

¾ In any communications with the code developer or code vendor about a suspected program error, provide a short concise description of the problem and all the necessary input data files so that the error can be reproduced. In cases where commercial sensitivity precludes this, special arrange-ments will need to be made.

¾ Contact the code developer if the meaning and definition of variables in the manuals are unclear and if support is needed in the implementation of special features.

12. Acknowledgements

The material presented in this document is a real team effort and thanks are due to the many people and organisations that have co-operated in its preparation, but in particular to the management and staff of the code developers and code vendors who have encouraged and supported the work, to the academic experts who have corrected some elementary mistakes of the editors, and the many CFD users from industry who have freely shared their experience in the use of CFD.

The production of the guidelines was organised by the Fluid Dynamics Laboratory of Sulzer Innotec, Ltd. in a contract issued by the ERCOFTAC SIG (Special Interest Group) on Quality and Trust in In-dustrial CFD. The major organisational and editorial work in association with the document and its preparation was carried out by the project leader at Sulzer Innotec, Dr. Michael Casey, assisted by Torsten Wintergerste.

The first version of the best practice guidelines was produced in May 1999 with major input from the following persons: Dr. G. Scheuerer, Dr. F. Menter, Dr. J. Ferreira and Dr. S. Phillipson of AEA Tech-nology, Dr. F. Mendonca of Computational Dynamics, Dr. M. Rabbitt of British Energy, Prof. M. A.

Leschziner of University of London, Prof. I. Castro of the University of Surrey, Dr. C. Lea of HSE, Dr.

S. Gilham of WSA, Dr. N. Hakimi of Numeca, Dr. P. Wild of Fluent and Dr. M. Casey, Dr. E Lang, Dr.

P. Holbein, Dr. M. Wehrli and T. Wintergerste of Sulzer Innotec.

The first version was reviewed and improved at a technical Workshop held in Zurich on June 21 and 22, 1999. The following invited persons were present, giving coverage of both academic and industrial points of view from a range of applications, levels of experience, and European countries: Dr. M. Ca-sey, Dr. E. Lang, Dr. P. Holbein, Dr. M. Wehrli, T. Wintergerste, Miss E. Wiederkehr of Sulzer Innotec, Dr. E. Benz (ABB), Dr. J. Vos (EPFL), Prof. A. Hutton (DERA), Dr. C. Carey (Alstom), Dr. A. Kelsey (HSE), Dr. N. Rhodes (Mott Macdonald), Dr. S. Gilham (WSA), Dr. P. Tucker (NAFEMS), Dr. P. An-dreasson (Vattenfall Utveckling), Prof. Ch. Hirsch (VUB), Prof. W. Rodi (Karlsruhe), Dr. F. Klimetzek (Daimler Chrysler Cars), Dr. W. Haase (Daimler Chrysler Aerospace), Dr. F. Archambeau (EDF), Dr.

H. Paillere (CEA), Dr. F. Mendonca (CD), Dr. S. Phillipson (AEA), Dr N. Hakimi (Numeca) and Dr. P.

Wild (Fluent). Many other persons offered their services for the workshop but could not take part either because numbers were limited or because the date was unsuitable.

An interim version based on the input from the workshop was produced by Sulzer Innotec for final edit-ing, with particularly high quality and helpful input to chapter 3 from Dr. Marc Wehrli (Sulzer Innotec) and to chapter 4 from Prof. Tony Hutton (DERA). Helpful revisions to the interim version were received from Dr. P. Andreasson (Vattenfall Utveckling), Dr. C. Lea and Dr. A. Kelsey (HSE), H.-D. Grein (NEC), Dr. P. Holbein (Sulzer Innotec), Dr. H. Pailliere (CEA), Dr. M. Rabbitt (British Energy) Dr P.

Drtina and Dr. H. Keck (Sulzer Hydro), Prof. Ch. Hirsch (VUB), Prof. I. Castro (Surrey University), Prof.

W. Rodi (Karlsruhe University), Dr. W. Haase (Daimler Chrysler Aerospace), Dr. F. Archambeau and Dr. N. Gay (EDF), Dr. S. Phillipson, Dr. G. Scheuerer and Dr. F. Menter (AEA).

A draft of the final version was prepared for the ERCOFTAC SIG meeting in Florence at the end of October 1999. After this meeting, some additional revisions of the chapter on turbulence modelling were received from Prof. Ian Castro, Dr. Georg Scheurer, Prof. Mike Leschziner and Prof. Tony Hutton, and these were incorporated into the final version.

The test cases were calculated by the code vendors and code developers whose names appear in the sections of chapter 9. Sulzer Innotec and the ERCOFTAC SIG extend many thanks to the manage-ment and staff of the code developers and code vendors who have encouraged and supported the work in this way. Individual thanks go to Dr. F. Mendonca, Dr. F. Archambeau, Dr. H. Pailliere, Dr. M.

Rabbitt, Dr. N. Hakimi, Dr. P. Wild, Dr. G. Scheuerer and Dr. J. Stokes

13. References

AIAA (1998), “AIAA guide for the verification and validation of computational fluid dynamics simula-tions”, AIAA G-077-1998.

Apsley, D., Chen, W-L., Leschziner, M. & Lien, F-S. (1997), “Non-linear eddy-viscosity modelling of separated flows”, IAHR J. Hydraulic Research, vol. 35, pp. 723-748.

Baldwin, W.S. & Lomax, H., (1978), “Thin-layer approximation and algebraic model for separated turbulent flows”, AIAA Paper 87-257.

Bradshaw, P. (1994), “Turbulence: the chief outstanding difficulty of our subject”, Experiments in Fluids, vol. 16, pp. 203 – 216.

Cebeci, T. & Smith, A.M.O., (1974), “Analysis of turbulent boundary layers”, Series in Appl. Math. &

Mech., Vol. XV, Academic Press.

Chieng, C.C. & Launder, B.E. (1980), “On the calculation of turbulent heat transfer downstream from an abrupt pipe expansion“, Journal of Heat Transfer, vol. 3, pp. 189-207

Daly B. J., Harlow F. H., (1970), “Transport Equations in Turbulence”, Physics of fluids, Vol 13, n°

11, 2634-2649.

Durbin, P. A., (1995), “Separated flow computations with the k-ε-υ2 model” AIAA Journal, Vol 33, No. 4, pp. 659-664.

Ekaterinaris, J. A., and Menter, F. R., (1994), “Computation of oscillating airfoil flows with one- and two-equation turbulence models”, AIAA Journal, Vol. 32, No.12, pp. 2359-2365.

ERCOFTAC/IAHR, (1999), “Workshop on draft tube flows”, June 20 - 23 Porjus Hydro Power Cen-ter, Sweden.

Ferreira, J.C. & Scheuerer, G. (1997), “Quality assurance in industrial CFD calculations”, Presenta-tion at the First European Meeting of the ERCOFTAC Special Interest Group on Quality and Trust in Industrial CFD, La Defense, Paris.

Ferziger, J.H. & Peric, M. (1997), “Computational methods for fluid dynamics”, Springer, Berlin.

Fisher, E.M. & Rhodes, N. (1996), “Uncertainty in computational fluid dynamics”, Proc. Mech. Eng., vol. 210, Part C: Journal of Mech. Eng. Sci., pp. 91 – 94.

Fletcher, C.A.J. (1991), “Computational techniques for fluid dynamics, vol. I & II”, Springer, Berlin.

Gatski, T.B. & Speziale, C.G. (1993), “On explicit algebraic stress models for complex turbulent flows“, J. Fluid Mech. Vol. 254, pp. 59 – 78.

Giles, M. B., (1990), “Non-reflecting boundary conditions for euler equation calculations”, AIAA Journal, Vol. 28, No. 12, pp. 2050-2058.

Girault, V. & Raviart, P. A., (1986), “Finite element methods for Navier-Stokes equations. Theory and algortihms”, Springer Series in Computational Mathematics, Vol. 5.

Grotjans, H. & Menter, F.R., (1998), “Wall Functions for General Application CFD Codes”, ECCO-MAS 98, Fourth European Computational Fluid Dynamics Conference, Athens.

Hall, R.C. & Cowan, I.R. (1998), “Modelling of atmospheric dispersion near buildings”, NAFEMS Int. Journal of CFD Case Studies, vol. 1, April 1998, pp. 7 – 18.

Hanjalic, K. (1994), “Advanced turbulence closure models: A view of current status and future pro-spects“, Int. J. Heat and Fluid Flow, pp. 178-203.

Hirsch, C. (1991), “Numerical computation of internal and external flows, vol. I & II”, Wiley, New York.

Ince, N.Z and Launder, B.E. (1995), “Three-dimensional and heat-loss effects on turbulent flow in a nominally two-dimensional cavity”, Int. J. Heat and Fluid Flow, 16, pp. 171-177.

Kato, M. & Launder , B.E. (1993), “The modelling of turbulent flow around stationary and vibrating square cylinders”, Proc. 9th Symp. on Turbulent Shear Flows, Kyoto, Japan.

Lamb, M. (1895), “Hydrodynamics”, University Press, Cambridge.

Launder B. E., (1989) “Second-moment closure : present...and future”, Intl J. Heat Fluid Flow 10, 282-300.

Launder, B.E. & Spalding, D.B. (1972), “Mathematical models of turbulence”, Academic Press.

Launder, B.E. & Spalding, D.B. (1974), “The numerical computation of turbulent flow”, Comp. Meth.

In Appl. Mech. And Engng., 3, pp 269-289.

Launder, B.E. (1984), “Second-moment closure: methodology and practice”, Chapter in Turbulence Models and their Applications, Vol. 2, Collection de la Direction des Etudes et Recherches d’Electricite de France, Eyrolles, Paris.

Launder, B.E. (1989), “Second moment closure: Present and future? “, Int. J. Heat and Fluid Flow, 10, p. 282.

Leschziner, M. (1990), “Modelling engineering flows with Reynolds stress turbulence closure“, J.

Wind Engineering and Industrial Aerodynamics, vol. 35, no. 21.

Leschziner, M. A., (1998), “The computation of turbulent engineering flows with turbulent transport closures”, UMIST Report, TFD/98/03, to be published by Springer.

Mayle, R. E., (1991), “The role of laminar turbulent transition in gas turbine engines” ASME Journal of Turbomachinery, Vol.113, pp. 506-537.

Menter, F.R. (1993), “Zonal two equation k-ω turbulence models for aerodynamic flows”, AIAA Pa-per 93-2906.

Menter, F.R. (1994a), “Two-equation eddy-viscosity turbulence models for engineering applica-tions”, AIAA Journal, vol. 32, No 8. pp. 1598-1605.

Menter, F.R. (1994b), “Eddy viscosity transport equations and their relation to the k-ε model”, NASA-TM-108854.

Menter, F.R. (1996), “A comparison of some recent eddy-viscosity turbulence models”, Transac-tions of the SAME, vol. 118, pp. 514 – 519.

Menter, F.R., Grotjans, H., Unger, F., (1997), “Numerical Aspects of Turbulence Modelling for the Reynolds Averaged Navier-Stokes Equations”, VKI Lecture Series 1997-02 on Computations Fluid Dynamics, Rhode Saint Genese.

Oden, J.T., Zienkiewicz, O.C., Gallagher, R.H. & Taylor, C. (1975), “Finite elements in Fluids, vol. I

& II”, John Wiley and Sons, New York.

Patankar, S.V. (1980), “Numerical heat transfer and fluid flow”, McGraw-Hill, New York.

Patel, V. C., Rodi, W. & Scheuerer, G. (1985), “Turbulence models for near-wall and low Reynolds number flows: a review”, AIAA Journal, vol. 23, No. 9, pp1308-1319.

Rizzi, A. & Vos, J. (1998), “Toward establishing credibility in computational fluid dynamics simula-tions”, AIAA Journal, vol. 36, no. 5, pp. 668 – 675.

Roache, P.J. (1972), “Computational fluid dynamics”, Hermosa Publishers, Albuquerque.

Roache, P.J., (1997), “Quantification of Uncertainty in Computational Fluid Dynamics”, Annual Rev.

Fluid Mech., Vol. 29, pp.123-160

Roache, P.J. (1998), “Verification and validation in computational science and engineering.”, Her-mosa Publishers, Albuquerque.

Rodi, W. & Spalding, D.B. (1970), “A two-parameter model of turbulence and its application to free jets”, Wärme- und Stoffübertragung, vol. 3, p. 85.

Rodi, W. (1981), “Progress in turbulence modelling for incompressible flows”, AIAA Paper 81-45, St. Louis.

Rodi, W., (1991), “Experience with two-layer models combining the k-ε model with a one-equation model near the wall”, AIAA paper 91-0216.

Rodi, W. (1993), “Turbulence models and their application in hydraulics”, 3rd edition, Balkema, Rot-terdam.

Rodi, W. (1997), “Comparison of LES and RANS calculations of the flow around bluff bodies”, Journal of Wind Engineering and Industrial Aerodynamics, vol.69-71, pp. 55-75.

Sarkar, S., Erlebacher, G., Hussaini, M.Y. & Kreiss, H. O. (1989), “The analysis and modelling of dilatational terms in compressible turbulence”, ICASE Report 89-79, Univ. Space Research Assoc.

Hampton, VA, USA.

Sarkar, S. & Speziale, C.G. (1990), “A simple non-linear model for the return to isotropy in turbu-lence”, Physics of Fluids A, vol. 2, pp. 84-93.

Savill, A. M (1996), “One point closures for transition”, chapter 6 in “Turbulence and Transition”, eds P.H. Alfredsson and D. Henningston, Kluwer Academic.

Schlichting, H. (1979), “Boundary Layer Theory”, McGraw-Hill.

Spalart, P.R. & Allmaras, S.R. (1992), “A one-equation turbulence model for aerodynamic flows”, AIAA Paper 92-0439.

Speziale, C.G. (1987a), “Second-order closure models for rotating turbulent flows”, Q. Appl Math., vol. 45, pp. 69-71.

Speziale, C.G. (1987b), “On non-linear k-L and k-ε models of turbulence”, Journal of Fluid Mechan-ics, vol. 178, pp. 459-475.

Strazisar, A.J. & Denton, J.D. (1995), “CFD code assessment in turbomachinery: a progress re-port”, Global Gas Turbine News, May/June 1995, pp. 12 – 14.

Tennekes, H. & Lumley, J.L. (1972), “A first course in turbulence”, MIT Press, Cambridge. Latest edition 1994.

Wilcox, D.C. (1998), “Turbulence modelling for CFD”, DCW Industries, Inc.

Wolfshtein, M.W. (1969), “The velocity and temperature distribution in a one-dimensional flow with turbulence augmentation and pressure gradient”, Int. J. Heat and Mass Transfer, 12, pp 301-312.

Yakhot, V., Orszag, S. A., Tangham, S., Gatski, T.B., and Speciale, C. G., (1992), “Development of turbulence models for shear flows by a double expansion technique”, Physics of Fluids A4 (7).

Zeman, O. (1990), “Dilatational dissipation: the concept and application in modelling compressible mixing layers”, Physics of Fluids A, Vol. 2, No. 2, pp 178-188.

Zienkiewicz, O.C. & Taylor, R.L. (1991), “The finite element method, Volume 2: Solid and fluid me-chanics dynamics and non-linearity”, McGraw-Hill, New York.

In document ercoftac_best_practice_guide.pdf (Page 89-94)